Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider to remove border feedback when drop location is clear #93839

Closed
bpasero opened this issue Mar 31, 2020 · 6 comments
Closed

Consider to remove border feedback when drop location is clear #93839

bpasero opened this issue Mar 31, 2020 · 6 comments
Assignees
Labels
polish Cleanup and polish issue verified Verification succeeded workbench-views Workbench view issues
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Mar 31, 2020

I find the border drop feedback visually quite overwhelming, given it is not needed in many cases. Should it only appear when needed? As for example in this case, why do I need to see it? Should it only show for when dragging view containers?

Kapture 2020-03-31 at 10 15 04

@sbatten
Copy link
Member

sbatten commented Apr 1, 2020

I would find it strange if we are not consistent. Eric suggested having a theme color for it which would allow a user/theme to hide it always if they find it not helpful.

@sbatten sbatten closed this as completed Apr 1, 2020
@bpasero
Copy link
Member Author

bpasero commented Apr 1, 2020

I don't like the looks especially because it is now different from editor drag and drop where we do not have such a border.

@sbatten
Copy link
Member

sbatten commented Apr 1, 2020

Editor is different because we always "split" there and this is always "insert". However, what I can do is only use the border on collapsed views, (the major reason it exists)... lmk

@Tyriar
Copy link
Member

Tyriar commented Apr 1, 2020

Seems like a the way to go to show it only when it adds value, otherwise it's inconsistent with the editor.

@sbatten
Copy link
Member

sbatten commented Apr 1, 2020

i'll try collapsed

@sbatten sbatten reopened this Apr 1, 2020
@sbatten sbatten added polish Cleanup and polish issue workbench-views Workbench view issues labels Apr 1, 2020
@sbatten sbatten added this to the March 2020 milestone Apr 1, 2020
@sbatten
Copy link
Member

sbatten commented Apr 2, 2020

To Verify:

  1. Try rearranging views inside a single view container (both sidebar and panel).
  2. Note that only collapsed views in sidebar use the border feedback.

@sbatten sbatten closed this as completed in 467c337 Apr 2, 2020
@Tyriar Tyriar added the verified Verification succeeded label Apr 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
polish Cleanup and polish issue verified Verification succeeded workbench-views Workbench view issues
Projects
None yet
Development

No branches or pull requests

3 participants