Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom editors: cancellation not working #93863

Closed
bpasero opened this issue Mar 31, 2020 · 0 comments
Closed

Custom editors: cancellation not working #93863

bpasero opened this issue Mar 31, 2020 · 0 comments
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug custom-editors Custom editor API (webview based editors) verified Verification succeeded
Milestone
March 2020

Comments

@bpasero
Copy link
Member

bpasero commented Mar 31, 2020

Refs: #93767

I am playing around with cancellation for custom editors (tried text, but probably also applies to custom editors). Steps:

  • add code to the resolve method of a custom editor to wait 10s
  • open a custom editor
  • close it before 10s reach

=> 🐛 the custom editor does not get cancelled properly

Kapture 2020-03-31 at 11 19 34
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Mar 31, 2020
@mjbvz mjbvz added this to the March 2020 milestone Mar 31, 2020
@mjbvz mjbvz added the custom-editors Custom editor API (webview based editors) label Mar 31, 2020
@mjbvz mjbvz closed this as completed in 12f2e2a Mar 31, 2020
@roblourens roblourens added the verified Verification succeeded label Apr 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug custom-editors Custom editor API (webview based editors) verified Verification succeeded
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
3 participants
@roblourens @bpasero @mjbvz