[rename on type] feedback incorrect after Rename

[egamma]

Testing #93808

• place the cursor inside the bo|dy tag of an html document
• F2 rename to body to 'foobar'
  -> The feedback is no longer selecting the entire tag:

[octref]

I think this is a decorator issue. Here's a simple repro:

• Run below code as an extension
• Open a plaintext file with only text body
• Put cursor at bod|y
• Rename to foobar
• 🐛 Decorator no longer covers whole region. As rename provider I provided a replace edit of body -> foobar, so I would expect that edit to keep the decorator on the new text foobar

const vscode = require('vscode');

function activate(context) {

	const smallNumberDecorationType = vscode.window.createTextEditorDecorationType({
		backgroundColor: 'red'
	});

	vscode.commands.registerCommand('extension.helloWorld', () => {
		vscode.window.activeTextEditor.setDecorations(smallNumberDecorationType, [new vscode.Range(0, 0, 0, 4)]);
	});
	
	vscode.languages.registerRenameProvider('plaintext', {
		provideRenameEdits(doc, pos, name) {
			const edit = new vscode.WorkspaceEdit();
			edit.set(vscode.window.activeTextEditor.document.uri, [
				new vscode.TextEdit(new vscode.Range(0, 0, 0, 4), name)
			]);
			return edit;
		}
	})
}

// this method is called when your extension is deactivated
function deactivate() {}

module.exports = {
	activate,
	deactivate
}

[alexdima]

@octref decorations should always be validated and reset after an edit by the owner of the decoration. You cannot trust that the editor understands the semantics of an edit it receives and behaves in a certain way. The editor does not discriminate between characters, so spaces, syntax characters or alphanumerical characters are treated the same. The editor maintains decorations as best as it can, but in this case the edits are being sent through a minifier of edits and the rename edits are further broken up into 4 edits, to replace b with fo and dy with bar.

On your side, you can also tweak the stickiness property to try to influence the way in which decorations grow or not when edits occur at their edges.