Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus hides the notebook title actions sometimes #93882

Closed
isidorn opened this issue Mar 31, 2020 · 4 comments
Closed

Focus hides the notebook title actions sometimes #93882

isidorn opened this issue Mar 31, 2020 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Mar 31, 2020

Refs: #93742

Move the focus from the cell container to the outer container. On the way the notebook title actions will be lost.
Also if you mouse click in an empty area the title actions will be lost.
You probably use some focused based context key which gets unset too agressivly.

6891bb6f-cd14-4962-99e9-3578e317a408

@rebornix rebornix added the bug Issue identified by VS Code Team member as probable bug label Mar 31, 2020
@rebornix rebornix added this to the March 2020 milestone Mar 31, 2020
@roblourens
Copy link
Member

roblourens commented Mar 31, 2020

When the webview gets focus, the editor gets a blur event, even though the webview is a child of the editor element...

@jrieken jrieken removed their assignment Apr 1, 2020
@roblourens roblourens modified the milestones: March 2020, April 2020 Apr 2, 2020
@rebornix
Copy link
Member

Fixed already.

@isidorn
Copy link
Contributor Author

isidorn commented Apr 30, 2020

I can still reproduce this. Following same steps in my original comment.
It is fine to push out of April imho.

@isidorn isidorn reopened this Apr 30, 2020
@isidorn isidorn added the verification-found Issue verification failed label Apr 30, 2020
@roblourens
Copy link
Member

Also if you mouse click in an empty area the title actions will be lost.

This I can repro, due to focus going to the webview like I mentioned.

@roblourens roblourens modified the milestones: April 2020, May 2020 Apr 30, 2020
@roblourens roblourens removed the verification-found Issue verification failed label May 6, 2020
@isidorn isidorn added the verified Verification succeeded label Jun 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants