Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebooks: double click on empty area should open new cell #93883

Closed
isidorn opened this issue Mar 31, 2020 · 6 comments
Closed

Notebooks: double click on empty area should open new cell #93883

isidorn opened this issue Mar 31, 2020 · 6 comments
Assignees
Labels
notebook under-discussion Issue is under discussion for relevance, priority, approach ux User experience issues
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Mar 31, 2020

#93742

Double click on empty area should open new cell
Same as double click on empty editor area opens new untitled editor, double click on tab area opens new tab..

@jrieken jrieken assigned roblourens and unassigned rebornix and jrieken Mar 31, 2020
@roblourens roblourens added this to the April 2020 milestone Mar 31, 2020
@rebornix rebornix added the ux User experience issues label Mar 31, 2020
@miguelsolorio
Copy link
Contributor

How about whenever we just click in an empty area it will add an empty cell and if you click away then the cell goes away?

@isidorn
Copy link
Contributor Author

isidorn commented Apr 2, 2020

That would be a new patter which we do not use anywhere, also easily to misclick into a bad situation. I personally prefer double click as we do in other areas.

@rebornix
Copy link
Member

rebornix commented Apr 7, 2020

@isidorn where do we support double clicking for inserting content? I didn't see this behavior in File Explorer.

@isidorn
Copy link
Contributor Author

isidorn commented Apr 7, 2020

@rebornix watch expressions, tab title area, empty editor area, tunnels view

@rebornix rebornix added the under-discussion Issue is under discussion for relevance, priority, approach label Apr 24, 2020
@rebornix rebornix modified the milestones: April 2020, May 2020 Apr 24, 2020
@roblourens roblourens modified the milestones: May 2020, June 2020 May 31, 2020
@roblourens roblourens modified the milestones: June 2020, July 2020 Jun 30, 2020
@roblourens
Copy link
Member

This is technically kind of a pain to do, I think I need to put in a fake list row with a height of whatever height is remaining on the page after the other rows to capture the double click. And this might predate the toolbar for inserting cells even. I will move this to the backlog.

@roblourens roblourens modified the milestones: July 2020, Backlog Jul 7, 2020
@roblourens
Copy link
Member

I'm gonna close this, I don't think it's expected

@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
notebook under-discussion Issue is under discussion for relevance, priority, approach ux User experience issues
Projects
None yet
Development

No branches or pull requests

5 participants