Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-entrant save #93901

Closed
jrieken opened this issue Mar 31, 2020 · 0 comments
Closed

Re-entrant save #93901

jrieken opened this issue Mar 31, 2020 · 0 comments
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug custom-editors Custom editor API (webview based editors) verified Verification succeeded
Milestone
April 2020

Comments

@jrieken
Copy link
Member

jrieken commented Mar 31, 2020

re #93767

I have an editing delegate that saves custom documents. What I am seeing while debugging is that save is called for resource X while there is still a pending save operation for resource X.
@mjbvz mjbvz added this to the March 2020 milestone Mar 31, 2020
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug custom-editors Custom editor API (webview based editors) labels Mar 31, 2020
@mjbvz mjbvz modified the milestones: March 2020, April 2020 Mar 31, 2020
@mjbvz mjbvz closed this as completed in bbb4b8e Apr 13, 2020
@jrieken jrieken added the verified Verification succeeded label Apr 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug custom-editors Custom editor API (webview based editors) verified Verification succeeded
Projects
None yet
Milestone
April 2020
Development

No branches or pull requests
2 participants
@jrieken @mjbvz