Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick pick: Ctrl+Home and Ctrl+End should go to the start and end of the list respectively #93922

Closed
Tyriar opened this issue Mar 31, 2020 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders macos Issues with VS Code on MAC/OS X quick-pick Quick-pick widget issues verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 31, 2020

#93641

Version: 1.44.0-insider (user setup)
Commit: d7d1147
Date: 2020-03-31T08:23:56.446Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18362


They do the same as home/end currently (work on the textbox).

@Tyriar Tyriar added the quick-pick Quick-pick widget issues label Mar 31, 2020
@Tyriar Tyriar changed the title Quick pick: Home and end should go to the start and end of the list respectively Quick pick: Ctrl+Home and Ctrl+End should go to the start and end of the list respectively Mar 31, 2020
@bpasero bpasero assigned chrmarti and bpasero and unassigned bpasero Mar 31, 2020
@bpasero bpasero added this to the March 2020 milestone Mar 31, 2020
@chrmarti
Copy link
Contributor

chrmarti commented Apr 1, 2020

Home/End work when you tab first to give focus to the list. While the focus is on the textbox, I expect Home/End to go to the textbox. (I suggest to leave this as it is.)

@bpasero
Copy link
Member

bpasero commented Apr 1, 2020

@chrmarti I think Daniel asks for Ctrl+Home / Ctrl+End to work on the list if I understand correctly.

But I see this as a feature request for the quick input widget itself, so moving off March.

@bpasero bpasero added the feature-request Request for new features or functionality label Apr 1, 2020
@bpasero bpasero modified the milestones: March 2020, Backlog Candidates Apr 1, 2020
@vscodebot
Copy link

vscodebot bot commented Apr 1, 2020

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@bpasero bpasero removed their assignment Apr 8, 2020
@connor4312 connor4312 added the verification-needed Verification of issue is requested label May 1, 2020
@roblourens roblourens added the verified Verification succeeded label May 1, 2020
@roblourens
Copy link
Member

Should it be cmd on mac?

@Tyriar
Copy link
Member Author

Tyriar commented May 3, 2020

Probably cmd+up/down as that matches what happens in the editor? @chrmarti any reason quickInput.ts isn't using commands and context keys here?

@Tyriar Tyriar reopened this May 3, 2020
@Tyriar Tyriar modified the milestones: April 2020, May 2020 May 3, 2020
@Tyriar Tyriar removed the verified Verification succeeded label May 3, 2020
@chrmarti chrmarti added bug Issue identified by VS Code Team member as probable bug and removed verification-needed Verification of issue is requested feature-request Request for new features or functionality labels Jun 2, 2020
@chrmarti
Copy link
Contributor

chrmarti commented Jun 4, 2020

Fixing by making CMD work on Mac. Converting these to commands is tracked with #98479.

@joaomoreno joaomoreno added the macos Issues with VS Code on MAC/OS X label Jun 4, 2020
@JacksonKearl JacksonKearl added the verified Verification succeeded label Jun 5, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders macos Issues with VS Code on MAC/OS X quick-pick Quick-pick widget issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

8 participants
@joaomoreno @roblourens @bpasero @Tyriar @connor4312 @JacksonKearl @chrmarti and others