Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenreader always repeats name of picker after every single item #93928

Closed
weinand opened this issue Mar 31, 2020 · 8 comments
Closed

Screenreader always repeats name of picker after every single item #93928

weinand opened this issue Mar 31, 2020 · 8 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues verified Verification succeeded
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Mar 31, 2020

Refs #93648
Orca 3.28.0 on Ubuntu 18.04.4 LTS

  • press F1
  • use cursor down key to step through items

Screen reader reads "File Picker" after every item.
Is this really necessary?

@bpasero bpasero added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues quick-pick Quick-pick widget issues labels Mar 31, 2020
@bpasero
Copy link
Member

bpasero commented Mar 31, 2020

@isidorn thoughts? easy to remove. we used to put the picker for each item already in the old impl

@weinand
Copy link
Contributor Author

weinand commented Mar 31, 2020

I have no experience with screen readers. I just report what I noticed.
Someone who has to rely on a screen reader should test this and provide feedback.

@isidorn
Copy link
Contributor

isidorn commented Mar 31, 2020

If I press F1 for the the screen reader does not read "File Picker" but reads "commands picker" at the end. If I press ctrl + p to get the File Picker than "File Picker" is read. Which is correct.
I think this is fine since we read it at the end and most screen reader users just stop the announcment and go to the next item.
Though let's see what @jvesouza has to say about this

@jvesouza
Copy link

@weinand @isidorn
When I press f1 and press down arrow, orca reads in the end of each command commands picker, and when I press ctrl+p orca reads in the end of command recently opened.
the text in the end is in my opinion not relevant information and could be deleted, as long as the effort was not too much. But at least for me, it's not much of a problem because I can quickly silence the orca pressing the ctrl key or move on to the next item.

@isidorn
Copy link
Contributor

isidorn commented Mar 31, 2020

@jvesouza thanks for feedback.
So I leave this up to @bpasero to decide as the owner of the feature
My suggestion is to remove the ending.

@isidorn isidorn removed their assignment Mar 31, 2020
@bpasero bpasero added this to the March 2020 milestone Mar 31, 2020
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Apr 1, 2020
@bpasero bpasero closed this as completed in 9e8080a Apr 1, 2020
@bpasero
Copy link
Member

bpasero commented Apr 1, 2020

Removed announcement of the picker you are in from all of quick open items.

@jvesouza
Copy link

jvesouza commented Apr 2, 2020

It was in my opinion very good. Less information to be read by the screen reader.
Thanks.

@isidorn
Copy link
Contributor

isidorn commented Apr 2, 2020

@jvesouza great, thanks for letting us know. Adding verified label.

@isidorn isidorn added the verified Verification succeeded label Apr 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants