Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow to scroll beyond last result #93940

Closed
isidorn opened this issue Mar 31, 2020 · 2 comments
Closed

Do not allow to scroll beyond last result #93940

isidorn opened this issue Mar 31, 2020 · 2 comments
Assignees
Labels
notebook polish Cleanup and polish issue
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Mar 31, 2020

Refs: #93742

Currenty we allow to scroll all the way down after the last result

We should at least always show the last cell output and the last cell
This way the screen can be completly empty which I find werid

Another problem is when revaling the last cell (for example from the problems view) the last cell is shown all the way at the top with a large empty area after it.

@jrieken jrieken removed their assignment Mar 31, 2020
@rebornix rebornix added the polish Cleanup and polish issue label Mar 31, 2020
@rebornix
Copy link
Member

The idea that allowing you to scroll beyond the last cell is when you have a large cell at then end of the document, when you are re-executing the query and fetching the results slowly, the window will shift up and down often. The same concept is from the editor which allows you to scroll beyond the last line.

Agree that we should not scroll the last cell to the very top of the view.

@rebornix
Copy link
Member

this can be disabled by editor.scrollBeyondLastLine.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
notebook polish Cleanup and polish issue
Projects
None yet
Development

No branches or pull requests

3 participants