Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

+ Code + Markdown weird design #93953

Closed
isidorn opened this issue Mar 31, 2020 · 3 comments
Closed

+ Code + Markdown weird design #93953

isidorn opened this issue Mar 31, 2020 · 3 comments
Assignees
@rebornix @miguelsolorio
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues notebook under-discussion Issue is under discussion for relevance, priority, approach ux User experience issues
Milestone
Backlog

Comments

@isidorn
Copy link
Contributor

isidorn commented Mar 31, 2020

Refs: #93742

I find the + Code + Markdown separator design a bit weird.
We do not use it anywhere else in vscode and it is not accessible - no way to focus into it.
I would remove it until other parts of the notebook ux are polished.
And this could ideally be done via context menus

Screenshot 2020-03-31 at 16 19 58
@jrieken jrieken assigned roblourens and miguelsolorio and unassigned rebornix and jrieken Mar 31, 2020
@rebornix rebornix added the ux User experience issues label Mar 31, 2020
@rebornix rebornix assigned rebornix and unassigned roblourens Mar 31, 2020
@rebornix rebornix added the under-discussion Issue is under discussion for relevance, priority, approach label Mar 31, 2020
@rebornix rebornix added this to the April 2020 milestone Mar 31, 2020
@rebornix
Copy link
Member

Let's look into this issue next iteration.

@rebornix rebornix added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Mar 31, 2020
@rebornix
Copy link
Member

rebornix commented Apr 8, 2020

We now allow tab into the toolbar with c22cc2b

@rebornix rebornix modified the milestones: April 2020, May 2020 Apr 24, 2020
@rebornix rebornix modified the milestones: May 2020, June 2020 Jun 1, 2020
@rebornix rebornix modified the milestones: June 2020, Backlog Jun 29, 2020
@jrieken
Copy link
Member

jrieken commented Feb 17, 2021

This has been changed to be framed and thereby looks more like buttons

@jrieken jrieken closed this as completed Feb 17, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

@miguelsolorio miguelsolorio

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues notebook under-discussion Issue is under discussion for relevance, priority, approach ux User experience issues
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@roblourens @rebornix @jrieken @isidorn @miguelsolorio