Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View picker not correctly update when moving views #94012

Closed
RMacfarlane opened this issue Mar 31, 2020 · 2 comments
Closed

View picker not correctly update when moving views #94012

RMacfarlane opened this issue Mar 31, 2020 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues verified Verification succeeded
Milestone

Comments

@RMacfarlane
Copy link
Contributor

Issue Type: Bug

Testing #93636

  1. Open quickpick and type view to show view picker
  2. Verify that "Outline" is shown under the "Sidebar / Explorer" section
  3. Drag "Outline" from there to its own container in the panel
  4. Open the view picker again, "Outline" is shown both under "Panel" and still under the "Sidebar / Explorer" section. I expected it to be removed from "Sidebar / Explorer"

VS Code version: Code - Insiders 1.44.0-insider (d7d1147, 2020-03-31T08:22:34.682Z)
OS version: Darwin x64 18.7.0

@RMacfarlane RMacfarlane changed the title View picker not correctly updated when moving views View picker not correctly update when moving views Mar 31, 2020
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues labels Apr 1, 2020
@bpasero bpasero added this to the March 2020 milestone Apr 1, 2020
@bpasero bpasero assigned sandy081 and unassigned bpasero Apr 1, 2020
@bpasero bpasero removed this from the March 2020 milestone Apr 1, 2020
@bpasero
Copy link
Member

bpasero commented Apr 1, 2020

This is not an issue with the new implementation, I copied the code over. Instead, the view picker needs to be made fit for the newly added support to move views.

Code pointer:

private doGetViewPickItems(): Array<IViewQuickPickItem> {

@sandy081 sandy081 added this to the March 2020 milestone Apr 1, 2020
@bpasero
Copy link
Member

bpasero commented Apr 1, 2020

@sandy081 thanks!

@RMacfarlane RMacfarlane added the verified Verification succeeded label Apr 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants