Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel toggle commands no longer seem to work properly #94035

Closed
eamodio opened this issue Mar 31, 2020 · 4 comments
Closed

Panel toggle commands no longer seem to work properly #94035

eamodio opened this issue Mar 31, 2020 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@eamodio
Copy link
Contributor

eamodio commented Mar 31, 2020

Refs: #93786

I have the following keybindings setup:

    {
        "key": "ctrl+1",
        "command": "workbench.debug.action.toggleRepl"
    },
    {
        "key": "ctrl+2",
        "command": "workbench.actions.view.problems"
    },
    {
        "key": "ctrl+3",
        "command": "workbench.action.output.toggleOutput"
    },

And they no longer seem to work

@eamodio eamodio added the bug Issue identified by VS Code Team member as probable bug label Mar 31, 2020
@sbatten sbatten added this to the March 2020 milestone Mar 31, 2020
@sbatten sbatten closed this as completed in d124102 Apr 1, 2020
@sbatten
Copy link
Member

sbatten commented Apr 1, 2020

To Verify:
Default Keybindings for Panels:
Problems (Ctrl/Cmd+Shift+M)
Output (Ctrl/Cmd+Shift+U)
Debug Console (Ctrl/Cmd+Shift+Y)
Terminal (Ctrl+`)

  1. Move all of these views to non-default locations (e.g. as views in the Activity Bar)
  2. Use the keybindings above to focus/toggle the views. This will hide the sidebar/panel if the view is already focused like before.

@eamodio
Copy link
Contributor Author

eamodio commented Apr 1, 2020

@sbatten I can't reproduce it anymore (and it only happen a few times -- but all back to back) but what happened was using (Ctrl+`) only toggled the panel, and didn't switch to the terminal. But once I toggled views on and off, I couldn't get it to happen again and everything works fine. Maybe some bad initial state?

@eamodio eamodio added the verified Verification succeeded label Apr 1, 2020
@sbatten
Copy link
Member

sbatten commented Apr 2, 2020

It's important that the views are not in their default position when testing. If you reset the view locations all would be well before and after the fix. If a new insiders has not been released since this afternoon my fix may not yet be in.

@sbatten sbatten removed the verified Verification succeeded label Apr 2, 2020
@sbatten
Copy link
Member

sbatten commented Apr 2, 2020

I removed the verified label on the assumption that my fix has not yet shipped since I am on mobile I did not check. If I am mistaken, please re add.

@connor4312 connor4312 added the verified Verification succeeded label Apr 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants