Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error or log when trying to use a disposed EnvironmentVariableCollection #94066

Closed
mjbvz opened this issue Mar 31, 2020 · 0 comments
Closed

Error or log when trying to use a disposed EnvironmentVariableCollection #94066

mjbvz opened this issue Mar 31, 2020 · 0 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Milestone
April 2020

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Mar 31, 2020 •
edited

Refs #93601

Repro

const collection = vscode.window.getEnvironmentVariableCollection(true);
collection.dispose();
collection.replace('key', 'value');

Bug
replace has no effect so I'd expect an error of some kind here
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues labels Apr 5, 2020
@Tyriar Tyriar added this to the April 2020 milestone Apr 5, 2020
@Tyriar Tyriar closed this as completed in fe36108 Apr 5, 2020
@connor4312 connor4312 added the verified Verification succeeded label Apr 29, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Milestone
April 2020
Development

No branches or pull requests
3 participants
@Tyriar @connor4312 @mjbvz