Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use isStringArry util #94138

Closed
jrieken opened this issue Apr 1, 2020 · 0 comments
Closed

Use isStringArry util #94138

jrieken opened this issue Apr 1, 2020 · 0 comments
Assignees
@alexdima
Labels
debt Code quality issues
Milestone
March 2020

Comments

@jrieken
Copy link
Member

jrieken commented Apr 1, 2020

We have this

vscode/src/vs/base/common/types.ts

Line 45 in 798a402

export function isStringArray(value: any): value is string[] {
which is kind duplicated by this

vscode/src/vs/workbench/api/common/extHostTypes.ts

Line 2429 in 3714004

function isStrArrayOrUndefined(arg: any): arg is string[] | undefined {

@jrieken jrieken assigned aeschli and alexdima and unassigned aeschli Apr 1, 2020
@alexdima alexdima added this to the March 2020 milestone Apr 1, 2020
@alexdima alexdima added the debt Code quality issues label Apr 1, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
debt Code quality issues
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
3 participants
@jrieken @alexdima @aeschli