Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook: query with large output freezes the editor for a few seconds on linux #94236

Closed
deepak1556 opened this issue Apr 2, 2020 · 5 comments
Assignees
Labels
info-needed Issue requires more information from poster notebook

Comments

@deepak1556
Copy link
Contributor

Testing #93742

  • Create notebook query label:electron $repo sort desc by created -> this has 873 results
  • Click show more
  • Editor is frozen until the result is populated

It looks like show more is trying to display all the 873 results, maybe we can throttle that ?

@deepak1556 deepak1556 changed the title Notebook: query with big output freezes the editor for a few seconds on linux Notebook: query with large output freezes the editor for a few seconds on linux Apr 2, 2020
@jrieken
Copy link
Member

jrieken commented Apr 2, 2020

The editor shouldn't freeze because the rendering happens in a separate process. But, yes there is no virtual rendering or anything like that. Tho, for me this works pretty well with 1000 items

@deepak1556
Copy link
Contributor Author

https://streamable.com/j8tq4r

For example in the above demo, there is a lag when I tried to collapse the outline panel after clicking show more and if I try to perform scroll outside the editor area, in the explorer area.

Maybe its specific to certain window operations that bubble up to embedding frame, like scroll, resize etc.

@jrieken
Copy link
Member

jrieken commented Apr 2, 2020

wow - for me this is all instant. Can you profile this please.

@rebornix
Copy link
Member

rebornix commented Apr 2, 2020

@deepak1556 can you try profile it? I'm wondering if it's because the resize listener in the webview attempts to send out enormous resize events. Otherwise it might be an Electron issue as I didn't see at all on macOS.

@rebornix rebornix added the info-needed Issue requires more information from poster label Apr 2, 2020
@github-actions
Copy link

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster notebook
Projects
None yet
Development

No branches or pull requests

3 participants