Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not using paging by scrolling #94258

Closed
sandy081 opened this issue Apr 2, 2020 · 1 comment
Closed

Why not using paging by scrolling #94258

sandy081 opened this issue Apr 2, 2020 · 1 comment
Assignees
Labels
timeline Timeline view issues
Milestone

Comments

@sandy081
Copy link
Member

sandy081 commented Apr 2, 2020

Testing #93820

I see paging is implemented using a special action/label Load More.... Why did not we consider implementing paging by scrolling just like how extensions viewlet is done?

Is this because of the current paging API design? If so the proposal here - #94178 will support paging by scrolling.

@eamodio eamodio added the timeline Timeline view issues label Apr 7, 2020
@eamodio eamodio added this to the Backlog Candidates milestone Apr 7, 2020
@eamodio
Copy link
Contributor

eamodio commented Apr 7, 2020

It was discussed, but we chose this simpler path to ship and when @isidorn suggested the extension viewlet paging, it seemed to have 2 requirements I couldn't meet -- 1) Only supports list items and we are thinking about possibly allowing tree items and 2) it needs to know the count of all the elements up front.

Although because of a recent major refactor to how the timeline is rendered #2 might not be an issues, but #1 would still be going forward.

@eamodio eamodio modified the milestones: Backlog Candidates, Backlog Apr 13, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
timeline Timeline view issues
Projects
None yet
Development

No branches or pull requests

2 participants