Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

org.freedesktop.Secret.Service Spam #94276

Closed
akvadrako opened this issue Apr 2, 2020 · 3 comments
Closed

org.freedesktop.Secret.Service Spam #94276

akvadrako opened this issue Apr 2, 2020 · 3 comments
Assignees

Comments

@akvadrako
Copy link

Every minute or so, vscode is making 2 dbus requests like this:

method call time=1585824223.108924 sender=:1.379 -> destination=:1.83 serial=23 path=/org/freedesktop/secrets; interface=org.freedesktop.Secret.Service; member=SearchItems
   array [
      dict entry(
         string "service"
         string "vscode-vscode.login"
      )
      dict entry(
         string "account"
         string "account"
      )
      dict entry(
         string "xdg:schema"
         string "org.freedesktop.Secret.Generic"
      )
   ]
method call time=1585824223.108964 sender=:1.379 -> destination=:1.83 serial=24 path=/org/freedesktop/secrets; interface=org.freedesktop.Secret.Service; member=SearchItems
   array [
      dict entry(
         string "service"
         string "vscode-github.login"
      )
      dict entry(
         string "account"
         string "account"
      )
      dict entry(
         string "xdg:schema"
         string "org.freedesktop.Secret.Generic"
      )
   ]

I don't think vscode should be constantly spamming with these requests. I have tried to disable every feature that might be causing them. This is my current settings.json:

{
    "workbench.enableExperiments": false,
    "extensions.autoUpdate": false,
    "telemetry.enableTelemetry": false,
    "update.mode": "none",
    "git.autorefresh": false,
    "extensions.autoCheckUpdates": false,
    "python.autoUpdateLanguageServer": false,
    "go.useGoProxyToCheckForToolUpdates": false
}
  • VSCode Version: 1.43.2
  • OS Version: Linux x64 5.3.0-40-generic snap

Steps to Reproduce:

  1. Open VSCode
  2. in shell, run dbus-monitor

Does this issue occur when all extensions are disabled?: Yes

@RMacfarlane
Copy link
Contributor

RMacfarlane commented Apr 2, 2020

This is being caused by two new built in extensions for providing auth support. Since each VSCode window has its own instance of the extension, they need to coordinate state. The current solution is to poll the keychain to see if another window has updated the value by logged in or out.

If you go to the extensions viewlet, you can search @builtin microsoft account and @builtin github authentication and disable both of them

@akvadrako
Copy link
Author

Thank you, that does seem to work. It would be nice if those extensions were not polling when there is no use for those accounts. AFAIK, I don't have anything enabled that could use a github or microsoft account.

@RMacfarlane
Copy link
Contributor

This should be fixed in the latest version of VS Code, 1.50.1. We no longer poll the keychain.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants