Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline providers that don't need URI's should be able to render on empty workbench #94303

Open
JacksonKearl opened this issue Apr 2, 2020 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality timeline Timeline view issues
Milestone

Comments

@JacksonKearl
Copy link
Contributor

#84297

Currently when the workbench has no ActiveTextEditor, the timeline view won't load anything. But there is a category of "workspace timeline" events that should be able to work without any active editor.

For instance:
Timeline of past/future sprints/iterations
Timeline counting down days till code freeze/GA/etc.
Timeline of git tags/releases

I think the provideTimeline should give an optional uri, and if an extension needs the URI they simply return undefined to be excluded from the timeline. But if not, they can elect to be shown even when theres no active editor.

@eamodio
Copy link
Contributor

eamodio commented Apr 2, 2020

💯 I've definitely been thinking about the same thing. Was going to make the uri optional, and am thinking about a UX to toggle the Timeline view into this mode (without having to have no editors open).

@eamodio eamodio added the timeline Timeline view issues label Apr 2, 2020
@eamodio eamodio added this to the April 2020 milestone Apr 2, 2020
@eamodio eamodio modified the milestones: April 2020, May 2020 May 4, 2020
@eamodio eamodio modified the milestones: May 2020, June 2020 Jun 2, 2020
@eamodio eamodio modified the milestones: June 2020, July 2020 Jun 30, 2020
@joaomoreno joaomoreno modified the milestones: July 2020, August 2020, Backlog Aug 7, 2020
@joaomoreno
Copy link
Member

@eamodio Moving this to Backlog.

@eamodio eamodio added the feature-request Request for new features or functionality label Nov 4, 2020
@lramos15 lramos15 assigned JacksonKearl and unassigned eamodio Oct 8, 2021
@JacksonKearl JacksonKearl modified the milestones: Backlog, On Deck Oct 8, 2021
@JacksonKearl
Copy link
Contributor Author

considering changing timeline provider to accept editor and/or workspace timelines

@JacksonKearl JacksonKearl assigned lramos15 and unassigned JacksonKearl Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality timeline Timeline view issues
Projects
None yet
Development

No branches or pull requests

4 participants