Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook run/stop cell should always be visible when hovering over output #94314

Closed
miguelsolorio opened this issue Apr 2, 2020 · 14 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues insiders-released Patch has been released in VS Code Insiders notebook verified Verification succeeded
Milestone

Comments

@miguelsolorio
Copy link
Contributor

image

When you hover over the output the run/stop button disappears. This should always be visible when hovering the cell because output is part of it.

@roblourens roblourens added this to the April 2020 milestone Apr 2, 2020
@rebornix rebornix added the bug Issue identified by VS Code Team member as probable bug label Apr 2, 2020
@rebornix rebornix mentioned this issue Apr 2, 2020
11 tasks
@JacksonKearl
Copy link
Contributor

JacksonKearl commented Apr 30, 2020

It looks like now the items will never hide if theres an output visible?
Notice focus is in top editor but bottom still has its items visible.

Not sure if this is intentional

image

@sbatten sbatten added verified Verification succeeded verification-found Issue verification failed and removed verified Verification succeeded labels Apr 30, 2020
@sbatten
Copy link
Member

sbatten commented Apr 30, 2020

adding label as per @JacksonKearl's comment, would argue that is not correct behavior.

@roblourens
Copy link
Member

It looks like you are hovering it. Are you? Otherwise I can't repro an issue.

@JacksonKearl
Copy link
Contributor

I'm not. Once the output appears, those widgets never go away

@roblourens
Copy link
Member

How did you execute the cell and did you click inside the output? We have to do weird stuff to figure out whether you are hovering the output and I'm guessing it got stuck.

@JacksonKearl
Copy link
Contributor

Can no longer repro

@JacksonKearl
Copy link
Contributor

Kapture 2020-05-01 at 9 27 59
Still seeing odd flickering if the cell being mousedover isn't highlighted:

@roblourens
Copy link
Member

The hover decorations should still be there when you hover the output and it looks like that stopped happening for you. Does that repro consistently?

@JacksonKearl
Copy link
Contributor

Not reliably, no.

I'm also seeing that the icons flicker between being shown between the two as I cross over the "insert cell" line:

Kapture 2020-05-01 at 10 00 33

@roblourens
Copy link
Member

That's weird

@roblourens roblourens modified the milestones: April 2020, May 2020 May 1, 2020
@roblourens roblourens reopened this May 1, 2020
@roblourens
Copy link
Member

Still can't repro. It's possible that there was a layout issue and cells were overlapping or something. Closing for now.

@JacksonKearl JacksonKearl added *not-reproducible Issue cannot be reproduced by VS Code Team member as described and removed *not-reproducible Issue cannot be reproduced by VS Code Team member as described labels May 29, 2020
@joaomoreno
Copy link
Member

Hmmmm 🤔

recording (15)

@miguelsolorio
Copy link
Contributor Author

Still seeing this weirdness. Noticed that this happens when you re-run a cell and then move your focus outside of that cell. Hovering over the output shows this.

Kapture 2020-06-04 at 8 44 52

@miguelsolorio miguelsolorio reopened this Jun 4, 2020
@roblourens
Copy link
Member

roblourens commented Jun 4, 2020

Note to self - I think this will just happen after the second time the cell is rendered, because the mouseenter/leave listeners are tied the first output id, not the cell id.

@roblourens roblourens modified the milestones: May 2020, June 2020 Jun 4, 2020
@roblourens roblourens added the debt Code quality issues label Jun 4, 2020
@connor4312 connor4312 added verified Verification succeeded and removed verification-found Issue verification failed verified Verification succeeded labels Jul 2, 2020
@miguelsolorio miguelsolorio added the verified Verification succeeded label Jul 6, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues insiders-released Patch has been released in VS Code Insiders notebook verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

8 participants
@joaomoreno @roblourens @rebornix @connor4312 @sbatten @JacksonKearl @miguelsolorio and others