Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search results need more space than the side bar allows #9435

Closed
tomduncalf opened this issue Jul 18, 2016 · 11 comments · Fixed by #43833
Closed

Search results need more space than the side bar allows #9435

tomduncalf opened this issue Jul 18, 2016 · 11 comments · Fixed by #43833
Assignees
Labels
feature-request Request for new features or functionality layout General VS Code workbench layout issues on-testplan release-notes Release notes issues ux User experience issues
Milestone

Comments

@tomduncalf
Copy link

  • VSCode Version: 1.3.1
  • OS Version: OS X

I believe that often, search results need more horizontal space to be truly useful than the sidebar allows, unless you expand the sidebar very wide (which then means less room for open files, and requires you to manually resize it bigger and smaller when going between search and editing, if you like to have the file tree open when editing).

My suggestion would be that search should have the option to display the results in a new tab, in a similar way to Atom or Sublime, or alternatively, the search pane could be relocatable to the bottom of the screen, so it would gain horizontal space in exchange for vertical.

@weinand weinand added the feature-request Request for new features or functionality label Jul 18, 2016
@sandy081 sandy081 added this to the Backlog milestone Jul 18, 2016
@sandy081 sandy081 added the search Search widget and operation issues label Feb 2, 2017
@adigov
Copy link

adigov commented Mar 31, 2017

search results need a separate tab, at least as an option. Current space is just too crowded - file name, file path, and results to make complete sense.

@ifeltsweet
Copy link

+1, absolutely, couldn't agree more.

@andrewdang17
Copy link

andrewdang17 commented Jun 27, 2017

Even text wrapping would be nice, I always find myself resizing the sidebar when searching. But a seperate tab is preferred, similar to Atom or Sublime.

@omaressameldin
Copy link

I was wondering if this feature would be coming along anytime soon?

@swatibhartiya
Copy link

Need to add a feature to search for files within a directory

@goldo
Copy link

goldo commented Jan 10, 2018

Would love it too! Thanks

@isidorn isidorn assigned isidorn and unassigned roblourens Feb 7, 2018
@isidorn isidorn modified the milestones: Backlog, February 2018 Feb 7, 2018
@isidorn isidorn added layout General VS Code workbench layout issues and removed search Search widget and operation issues labels Feb 7, 2018
@adamreisnz
Copy link

As soon as this lands I'll be able to switch from Atom to VSCode! 👍

@isidorn
Copy link
Contributor

isidorn commented Feb 22, 2018

From tomorrow's insiders it is possible to put the search viewlet into the panel area using the setting
"search.location": "panel"
Please note that we did not yet polish the UX inside the settings view to use all these additional horizontal space. We plan to improve this next milestone, when we plan to polish this feature.
More details about what is done can be found in the PR #43833

@balta2ar
Copy link

@isidorn Is there a picture to see how it looks now (for those who aren't using insider's build)?

@isidorn
Copy link
Contributor

isidorn commented Feb 23, 2018

screen shot 2018-02-23 at 11 00 00

@dubeg
Copy link

dubeg commented Feb 28, 2018

Is there a way to add a keyboard binding to dismiss the search panel with escape?

I got...

    {
        "key": "escape",
        "command": "workbench.action.closePanel"
    }

But I'm missing the when clause. Is there something like when: panelHasFocus ?

@isidorn isidorn added the release-notes Release notes issues label Mar 2, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality layout General VS Code workbench layout issues on-testplan release-notes Release notes issues ux User experience issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.