Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problems view should align counters to the right and have them always visible #94530

Closed
joaomoreno opened this issue Apr 6, 2020 · 3 comments
Closed

Problems view should align counters to the right and have them always visible #94530

joaomoreno opened this issue Apr 6, 2020 · 3 comments
Assignees
@sandy081
Labels
error-list Problems view feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
April 2020

Comments

@joaomoreno
Copy link
Member

This is now more obvious when moving Problems to the sidebar, which I'm really digging (馃 @sbatten):

image
@sandy081 sandy081 added error-list Problems view feature-request Request for new features or functionality labels Apr 6, 2020
@sandy081 sandy081 added this to the Backlog milestone Apr 6, 2020
@sandy081
Copy link
Member

sandy081 commented Apr 6, 2020

This is now more obvious when moving Problems to the sidebar,

Nothing to do with moving to sidebar. This is also same when you move panel to left or right. It shall depend on width.

@joaomoreno
Copy link
Member Author

That's what I mean: this issue now becomes more obvious when we move Problems to the sidebar, which typically is more narrow.

@sandy081 sandy081 modified the milestones: Backlog, April 2020 Apr 17, 2020
@sandy081 sandy081 added the verification-needed Verification of issue is requested label Apr 17, 2020
@sandy081
Copy link
Member

Fixed this at base viewpane layer so that other views can adopt it and be consistent.
.wide class is added to .pane-body if viewpane is wider that 600 px.

Adopted Problems and Search views accordingly.
Change in Search view: Wide semantics changed from 1000 to 600 px.
1000 px is too wide hence went with 600 px after trying out. I am open to change it if someone has better suggestion.

@roblourens FYI

@jrieken jrieken added the verified Verification succeeded label Apr 28, 2020
@jrieken jrieken mentioned this issue Apr 28, 2020
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
error-list Problems view feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
April 2020
Development

No branches or pull requests
3 participants
@joaomoreno @jrieken @sandy081