Trim Final Newlines integrates poorly with EditorConfig for Windows files

[mcandre]

Overall VSCode does a decent job integrating with EditorConfig. Including the Trim Final Newlines setting once enabled.

However, where final EOLs are disabled (such as for .AHK and other Windows-centric files), then Trim Final Newlines fails to delete final EOLs. How can we make sure that VSCode respects more EditorConfig configurations?

In particular:

• Binary files should be ignored/preserved as-is.
• .PATCH files should be ignored/preserved as-is.
• Text files with contents consisting of exactly one EOL (CRLF, LF, or CR) should be ignored/preserved as-is.
• .CS, .FS, .FSX, .VBS, .BAT, .COM, .PS1, .AHK, and other Windows-centric files should have zero trailing EOLs at the end of the buffer.
• All other files should have exactly one (LF) EOL at the end of the buffer.

VSCode 1.43.2
Windows 10

[snebjorn]

I 2nd this. The "Files: Eol" settings should respect the .editorconfig setting

Auto (default) shouldn't just look at which OS is used. But first look at what EOL .editorconfig suggests for the file type and if none is configured it should work as today.

[hepcat72]

I don't know if my issue is associated with this issue (as I have the macOS version), but I had 3 .tsv files, each ending in a single newline character (which I could copy and paste and confirm), yet editorconfig was complaining that the final line of each of these 3 files was missing a newline character (\n) (aka "linefeed"). I had to have my files (apparently) ending in 2 consecutive newline characters to silence the editorconfig errors. Again, I could copy and paste those two newlines, each showing as 2 empty numbered lines in the editor.

I closed VS code. Then later, when I examined the files on the command line, they all seemed to end in a single newline character, so I re-opened the project in VS Code, thinking it had inserted carriage returns, and to my surprise, it displayed a single newline at the end of each file. I checked each file for the presence of carriage returns (using a perl one-liner matching \r) and found none. I'm dumbfounded as to why it previously displayed 1 newline character at the end of these files when editorconfig complained there were none - and displayed 2 consecutive copyable newline characters that silenced the editorconfig error - and which my checks confirm constituted only 1.

Should I create a new issue for this or is this associated with this issue?

[bpasero]

Originally came in via contribution it seems: #33947

[VSCodeTriageBot]

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

[VSCodeTriageBot]

🙂 This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!