Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #94724 #95131

Merged
merged 1 commit into from Apr 15, 2020
Merged

fixes #94724 #95131

merged 1 commit into from Apr 15, 2020

Conversation

sbatten
Copy link
Member

@sbatten sbatten commented Apr 13, 2020

This PR fixes #94724

@sbatten sbatten self-assigned this Apr 13, 2020
@sbatten sbatten added this to the March 2020 Recovery milestone Apr 13, 2020
@sbatten sbatten requested a review from Tyriar April 13, 2020 16:20
@Tyriar
Copy link
Member

Tyriar commented Apr 13, 2020

Any insights into why this fixes it?

@sbatten
Copy link
Member Author

sbatten commented Apr 13, 2020

@Tyriar, the deleted code is from old drag and drop. When the Composite action (in this case, whichever panel tab is at the end that hides when Problems becomes visible) gets disposed, it is clearing the data transfer object that is being used by the current drag and drop operation. At that point the drag breaks because it expects that there should be a valid transfer object since it is all managed by one observer.

@Tyriar Tyriar merged commit 7e9edfa into microsoft:release/1.44 Apr 15, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@sbatten sbatten

Labels
None yet
Projects
None yet
Milestone
March 2020 Recovery 2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sbatten @Tyriar