Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define keybinding button should match blue button style used elsewhere #95268

Closed
Tyriar opened this issue Apr 14, 2020 · 1 comment
Closed

Define keybinding button should match blue button style used elsewhere #95268

Tyriar opened this issue Apr 14, 2020 · 1 comment
Assignees
@sandy081 @miguelsolorio
Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue ux User experience issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
November 2020

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 14, 2020

We don't use round corners anywhere else:
image

Can we match this?
image
@sandy081 sandy081 added polish Cleanup and polish issue ux User experience issues labels Apr 16, 2020
@sandy081 sandy081 added this to the Backlog milestone Apr 16, 2020
@sandy081 sandy081 modified the milestones: Backlog, November 2020 Nov 3, 2020
@sandy081
Copy link
Member

sandy081 commented Nov 3, 2020

This also changes all other similar buttons using floating click widget.

image

image

@miguelsolorio miguelsolorio added the verification-needed Verification of issue is requested label Dec 1, 2020
@bpasero bpasero added the verified Verification succeeded label Dec 1, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

@miguelsolorio miguelsolorio

Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue ux User experience issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
November 2020
Development

No branches or pull requests
5 participants
@bpasero @Tyriar @sandy081 @miguelsolorio and others