Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom "large" title scrollbar is not selectable on its full height #95413

Closed
VipSaran opened this issue Apr 16, 2020 · 4 comments
Closed

Bottom "large" title scrollbar is not selectable on its full height #95413

VipSaran opened this issue Apr 16, 2020 · 4 comments
Assignees

Comments

@VipSaran
Copy link

VipSaran commented Apr 16, 2020

Version: 1.44.0 (system setup)
Commit: 2aae1f2
Date: 2020-04-07T23:31:18.860Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18363

Steps to Reproduce:

  1. choose Large for workbench.editor.titleScrollbarSizing and make the bottom scroll bar appear
  2. mouse over it

Does this issue occur when all extensions are disabled?: Yes

When going accross it vertically (top to bottom) the cursor switches to "resize" (for collapsed terminal bar):
https://imgur.com/qFRjuCN

Same happens also when the terminal is open.

Result: "large" title scrollbar on bottom of the screen is selectable only in top 60% of its height --> effectively nagating its purpose.

@sbatten
Copy link
Member

sbatten commented Apr 17, 2020

I am not sure what would make this better since you still need that drag cursor. If the drag cursor response area shrinks, it will be difficult to drag.

@VipSaran
Copy link
Author

The problem with the invisible 4px area of the terminal/output (orthogonal-start, which is used to trigger its drag) is that its z-index is keeping it atop of the horizontal scrollbar, thus effectively taking the 4px from it.

As a best solution/compromise I see that the orthogonal-start is moved to be ontop of bottom status bar (i.e. items-container), like this:
image

That way it won't obscure the bottom scrollbar and its drag-point will allign with the top of the status bar:
https://imgur.com/L5wIn3T

What's best, the bottom (plugin) controls are on top of the orthogonal-start drag area, so they're also not obscured by it:
image

Win-win!

I'm sure you'll be able to work something out ;)

@sbatten
Copy link
Member

sbatten commented Jun 9, 2020

any thoughts on this @joaomoreno ?

@joaomoreno
Copy link
Member

This was already mitigated in: #96928

@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants