Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account icon looks incorrectly in Insiders build #95437

Closed
IllusionMH opened this issue Apr 16, 2020 · 4 comments
Closed

Account icon looks incorrectly in Insiders build #95437

IllusionMH opened this issue Apr 16, 2020 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug icons-product Issues for in-product icons verified Verification succeeded
Milestone

Comments

@IllusionMH
Copy link
Contributor

Issue Type: Bug

Account icon changed from outline with silhouette to something unhuman (maybe rotated husky face)
image

/cc @misolori

VS Code version: Code - Insiders 1.45.0-insider (6e9a34c, 2020-04-16T05:45:56.832Z)
OS version: Windows_NT x64 10.0.18363

System Info
Item Value
CPUs Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz (12 x 3192)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: enabled
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off_ok
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 31.72GB (16.36GB free)
Process Argv
Screen Reader no
VM 0%
Extensions: none
@gjsjohnmurray
Copy link
Contributor

I think it lacks any contrast between the background within the circle and the what I assume is supposed to be the body of the person (highlighted in red by me below on a clip from how it appears with 'Quiet Light' theme)

image

@IllusionMH
Copy link
Contributor Author

IllusionMH commented Apr 16, 2020

My theory is that addition of circle around silhouette went wrong and filled whole area. Therefore we can only see couple of empty areas from previous outline. (Hi Invisible man ✋ )

Otherwise it will be really bold solid icon where other icons were switched to light outline variants

@miguelsolorio miguelsolorio self-assigned this Apr 16, 2020
This was referenced Apr 16, 2020
@miguelsolorio
Copy link
Contributor

This appears to be an icon rendering issue on Windows, looking into this now. Icon should look like this:

image

@miguelsolorio miguelsolorio added bug Issue identified by VS Code Team member as probable bug icons-product Issues for in-product icons labels Apr 16, 2020
@miguelsolorio miguelsolorio added this to the April 2020 milestone Apr 16, 2020
@miguelsolorio
Copy link
Contributor

Should be fixed now:

image

@isidorn isidorn added the verified Verification succeeded label Apr 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug icons-product Issues for in-product icons verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants