welcome view content layout is broken?

[sandy081]

welcome view layout is handled by the ViewPane parent class

vscode/src/vs/workbench/browser/parts/views/viewPaneContainer.ts

Lines 335 to 340 in 7fa1bef

	protected layoutBody(height: number, width: number): void {
	this.viewWelcomeContainer.style.height = `${height}px`;
	this.viewWelcomeContainer.style.width = `${width}px`;
	this.scrollableElement.scanDomNode();
	}

None of the sub classes (views) are calling super.layoutBody(). Does it mean that if any of these views has welcome view content then welcome view is not layout correctly?

[joaomoreno]

I actually went through all the subclasses and added super.renderBody() to all renderBody() methods. Forgot to do the same for layoutBody...

[sandy081]

Verified by code review