Register mimetype for *.code-workspace #95637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaomoreno
added
linux
Tyriar
approved these changes
May 26, 2020
|
Was there anything else needed to merge this? |
|
Ping @Tyriar @joaomoreno |
Tyriar
approved these changes
Sep 9, 2020
Tyriar
reviewed
Sep 9, 2020
| @@ -46,17 +47,24 @@ ln -sf /usr/share/@@NAME@@/bin/@@NAME@@ %{_bindir}/@@NAME@@ | |||
| # fi | |||
| #fi | |||
|
|
|||
| # Update mimetype database to pickup workspace mimetype | |||
| update-mime-database /usr/share/mime &> /dev/null || : | |||
There was a problem hiding this comment.
@luqmana should we also be testing for the executable's existence here?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Register a new mimetype for workspace files so that they aren't just classified as text/plain. This lets users specify VS Code to open workspace files without also associating it with every other text/plain type file.
Fixes: #59040 and #80818
The deb and rpm scripts were updated to install the mimetype but unfortunately Snap doesn't support this yet (see https://forum.snapcraft.io/t/allow-snaps-to-register-new-mime-types/6467/7).