find in files - inconsistency in marking results as "dirty"

[JacksonKearl]

BTW looks like there is inconsistency in marking results as "dirty" - removing file from result prevents next search to be performed immediately (requires Enter ), but removing one match from file that has several - allows immediate search.

Originally posted by @IllusionMH in #91901 (comment)

[IllusionMH]

Looks like middle ground and place where logic is missing is

vscode/src/vs/workbench/contrib/search/common/searchModel.ts

Lines 580 to 595 in 652bd16

	private onFileChange(fileMatch: FileMatch): void {
	let added: boolean = false;
	let removed: boolean = false;
	if (!this._fileMatches.has(fileMatch.resource)) {
	this.doAdd(fileMatch);
	added = true;
	}
	if (fileMatch.count() === 0) {
	this.doRemove(fileMatch, false, false);
	added = false;
	removed = true;
	}
	if (!this._replacingAll) {
	this._onChange.fire({ elements: [fileMatch], added: added, removed: removed });
	}
	}

This one always receives FileMatch and can only calculate if whole file was added/removed, but doesn't know if it was "updated" therefore won't be handled later

vscode/src/vs/workbench/contrib/search/common/searchModel.ts

Lines 721 to 723 in 652bd16

	if (e.removed) {
	this._hasRemovedResults = true;
	}

It feels like onFileChange should also receive optional parameter - changed Match and verify if this match is in its list of removed lines. Is it proper fix or wrong approach?

[JacksonKearl]

Ended up making it so the file match will explicitly include whether results are removed in its onchange event.