Stepping when in a skipped frame navigates me back out to the last non skipped frame

[alexr00]

Repro steps:
Debug something that will have skipped frames
Break in
Step into a function that will be in in a skipped frame
Keep stepping over some stuff in the skipped frame

Expected: I intentionally stepped in, I expect to go to that file
Actual: each time I step over while in a skipped frame in I'm shown the editor that the last non skipped frame was from. This means I have to keep re-opening the frame I care about.

[isidorn]

Good point and agree with your request.
I will not have time this milestone, thus assigning to On-Deck.
Here's a code pointer in case someone wants to tackle it in the meantime https://github.com/microsoft/vscode/blob/1af3b9dce3d2ead4c3c0bb010dc47a4752af13d1/src/vs/workbench/contrib/debug/browser/debugService.ts#L1144
Basically the autoFocus of frames should take into account the previous one if it is deempahisezed.

[dongskyler]

I'd like to tackle this issue.

@isidorn The code pointer link doesn't seems to work. Could you help me out here? Thank you.
https://github.com/microsoft/vscode/blob/1af3b9dce3d2ead4c3c0bb010dc47a4752af13d1/src/vs/workbench/contrib/debug/browser/debugService.ts#L1144

[isidorn]

Sorry, my mistake.
Here's a correct one

vscode/src/vs/workbench/contrib/debug/browser/debugService.ts

Line 1144 in ee9f5d1

stackFrame = first(callStack, sf => !!(sf && sf.source && sf.source.available && sf.source.presentationHint !== 'deemphasize'), undefined);

[dongskyler]

@isidorn Thank you. That’s very helpful. I’m looking into the issue. My initial impression is: it seems, near Line 1144, the if (!stackFrame) section isn’t taking some corner cases into considerations. I’ll post some updates shortly.

[dongskyler]

Just to give an update. I'm still working on it. This will be my first contribution to VS Code. Sorry it is taking some time, but I am making progress.

[isidorn]

No hurries. Take your time.