Clean up CallstackOrException telemetry in typescript-language-features #96108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One was actually SystemMetaData, all others were either dropped or replaced with sanitized versions classifiable as SystemMetaData.
amcasey
commented
Apr 25, 2020
| /* __GDPR__FRAGMENT__ | ||
| "TypeScriptRequestErrorProperties" : { | ||
| "command" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }, | ||
| "message" : { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" }, |
There was a problem hiding this comment.
I believe dropping these causes them to be on the server side?
amcasey
commented
Apr 25, 2020
| if (!message) { | ||
| return ''; | ||
| } | ||
| return message.replace(new RegExp(`${escapeRegExp(version.path)}[/\\\\]tsserver.js:`, 'gi'), 'tsserver.js:'); | ||
| const regex = /(tsserver)?(\.(?:ts|tsx|js|jsx)(?::\d+(?::\d+))?)\)?$/igm; |
There was a problem hiding this comment.
This moves us from an exclusion list to an inclusion list, so it should be impossible for customer data to slip through.
|
FYI @mjbvz |
|
Thanks @amcasey! Merging this to VS Code but just make sure these changes won't break the exception queries TypeScript use to open issues |
|
@mjbvz It will definitely break our tools, but we're prepared to make the necessary changes. |
This was referenced Apr 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One was actually SystemMetaData, all others were either dropped or replaced with sanitized versions classifiable as SystemMetaData.