Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing saveAs csv file type in file saveAs dialog #96283

Closed
lkhatkar opened this issue Apr 27, 2020 · 10 comments
Closed

Missing saveAs csv file type in file saveAs dialog #96283

lkhatkar opened this issue Apr 27, 2020 · 10 comments
Assignees
Labels
feature-request Request for new features or functionality file-io File I/O macos Issues with VS Code on MAC/OS X verified Verification succeeded windows VS Code on Windows issues
Milestone

Comments

@lkhatkar
Copy link

Missing saveAs csv file type file saveAs dialog. I needed to save exported csv content from sqlite3 but could not found any extension type as csv in file save as dialog.

@lkhatkar lkhatkar changed the title Missing saveAs csv file type in language identification Missing saveAs csv file type in file saveAs dialog Apr 27, 2020
@alexr00
Copy link
Member

alexr00 commented Apr 28, 2020

Can you provide steps for how to reproduce your problem?

@alexr00 alexr00 added the info-needed Issue requires more information from poster label Apr 28, 2020
@github-actions
Copy link

github-actions bot commented May 5, 2020

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@github-actions github-actions bot closed this as completed May 5, 2020
@lkhatkar
Copy link
Author

lkhatkar commented May 5, 2020

Steps to reproduce:
Open any .csv file,
Click on File->SaveAs
SaveAs dialog opens and it is missing saveAs csv file type

@alexr00
Copy link
Member

alexr00 commented May 5, 2020

What OS and version of VS Code are you using?

@lkhatkar
Copy link
Author

lkhatkar commented May 5, 2020

Version: 1.44.2 (user setup)
Commit: ff91584
Date: 2020-04-16T16:36:23.138Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18362

@alexr00
Copy link
Member

alexr00 commented May 11, 2020

@alexdima this appears to be because the ModeService doesn't know the file extension csv.

@alexr00 alexr00 removed the info-needed Issue requires more information from poster label May 11, 2020
@alexr00 alexr00 reopened this May 11, 2020
@alexdima alexdima added the windows VS Code on Windows issues label May 12, 2020
@alexdima
Copy link
Member

I could not reproduce on macOS.

@alexdima
Copy link
Member

I think there will always be file extensions which we don't know, but I agree it is a bit ugly that the current file's extension is not shown in this list. @bpasero perhaps the list coming in from the mode service can be enhanced with the current file's extension if the current file's extension is not in that list?

I think the workaround for now is to choose "No extension" and just type file2.csv. Leaving it to @bpasero if he wants to add automatically the current file extension.

image

@alexdima alexdima assigned bpasero and unassigned alexdima May 12, 2020
@bpasero
Copy link
Member

bpasero commented May 12, 2020

This might require help from Electron.

@bpasero bpasero added this to the May 2020 milestone May 12, 2020
@bpasero bpasero added file-io File I/O under-discussion Issue is under discussion for relevance, priority, approach labels May 12, 2020
@bpasero bpasero added feature-request Request for new features or functionality verification-needed Verification of issue is requested macos Issues with VS Code on MAC/OS X and removed under-discussion Issue is under discussion for relevance, priority, approach labels May 13, 2020
@bpasero
Copy link
Member

bpasero commented May 13, 2020

Verification (Windows, macOS)

  • open a *.csv file
  • save as
  • you should see CSV file extension as first entry in the dropdown

@lramos15 lramos15 added verified Verification succeeded and removed verification-needed Verification of issue is requested labels Jun 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality file-io File I/O macos Issues with VS Code on MAC/OS X verified Verification succeeded windows VS Code on Windows issues
Projects
None yet
Development

No branches or pull requests

5 participants