Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positives in unhandled promise rejection #963

Closed
jrieken opened this issue Dec 3, 2015 · 1 comment
Closed

False positives in unhandled promise rejection #963

jrieken opened this issue Dec 3, 2015 · 1 comment
Assignees
@jrieken
Milestone
Jan 2016

Comments

@jrieken
Copy link
Member

jrieken commented Dec 3, 2015

We have code that warns about unhandled rejected promises. Due to a bug in nodejs/electron we might produce false positives
@jrieken jrieken self-assigned this Dec 3, 2015
@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) and removed bug Issue identified by VS Code Team member as probable bug labels Dec 3, 2015
@jrieken jrieken mentioned this issue Dec 3, 2015
Closed
@egamma egamma modified the milestone: Backlog Dec 10, 2015
@jrieken
Copy link
Member Author

jrieken commented Jan 19, 2016

this is actually because of #2107

@jrieken jrieken removed the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Jan 19, 2016
@jrieken jrieken modified the milestones: Jan 2016, Backlog Jan 19, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
None yet
Projects
None yet
Milestone
Jan 2016
Development

No branches or pull requests
2 participants
@egamma @jrieken