Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Titles are broken in panel #96465

Closed
sandy081 opened this issue Apr 28, 2020 · 4 comments
Closed

Titles are broken in panel #96465

sandy081 opened this issue Apr 28, 2020 · 4 comments
Assignees
@sbatten @sandy081
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-views Workbench view issues
Milestone
April 2020

Comments

@sandy081
Copy link
Member

  1. Move terminal to sidebar
  2. Move problems to sidebar and split with the terminal
  3. Reset view locations

Problems title is shown with icon

image
@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug workbench-views Workbench view issues labels Apr 28, 2020
@sandy081 sandy081 added this to the April 2020 milestone Apr 28, 2020
@sandy081
Copy link
Member Author

Caused by 66efeeb

@sbatten
Copy link
Member

sbatten commented Apr 28, 2020

there are a few issues related to this, let me aggregate

@sbatten
Copy link
Member

sbatten commented Apr 28, 2020

resolved the rest to #96121

@sandy081
Copy link
Member Author

sandy081 commented Apr 28, 2020 •
edited

Even though this issue got surfaced because of the change 66efeeb the core problem lies while registering the panel. Panel is getting registered with icon which which should not be.

@sandy081 sandy081 mentioned this issue Apr 28, 2020
Closed
@mjbvz mjbvz added the verified Verification succeeded label Apr 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sbatten sbatten

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-views Workbench view issues
Projects
None yet
Milestone
April 2020
Development

No branches or pull requests
3 participants
@sbatten @sandy081 @mjbvz