Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show an error notification when the user cancels the sign-in #96502

Closed
kieferrm opened this issue Apr 29, 2020 · 0 comments
Closed

Don't show an error notification when the user cancels the sign-in #96502

kieferrm opened this issue Apr 29, 2020 · 0 comments
Assignees
@RMacfarlane
Labels
authentication Issues with the Authentication platform bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
November 2020

Comments

@kieferrm
Copy link
Member

Issue Type: Bug

Testing #96313.

  1. Create a new local folder with a couple of files
  2. Open VS Code on this folder
  3. Go to the SCM viewlet and choose Publish to GitHub
    -> VS Code asked me whether it's OK to proceed with the sign-in
  4. Close the dialog
    -> error notification is shows that the I didn't give consent.

This is an unnecessary notification. We should not show it.

VS Code version: Code - Insiders 1.45.0-insider (abb4a35, 2020-04-28T05:36:25.810Z)
OS version: Windows_NT x64 10.0.18363
@RMacfarlane RMacfarlane added authentication Issues with the Authentication platform bug Issue identified by VS Code Team member as probable bug labels Apr 29, 2020
@RMacfarlane RMacfarlane modified the milestones: Backlog, November 2020 Nov 3, 2020
@rzhao271 rzhao271 added the verified Verification succeeded label Nov 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@RMacfarlane RMacfarlane

Labels
authentication Issues with the Authentication platform bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
November 2020
Development

No branches or pull requests
4 participants
@RMacfarlane @kieferrm @rzhao271 and others