Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Locking a cell removes squiggles #96529

Closed
jrieken opened this issue Apr 29, 2020 · 3 comments
Closed

Locking a cell removes squiggles #96529

jrieken opened this issue Apr 29, 2020 · 3 comments
Assignees
@roblourens @jrieken
Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded
Milestone
April 2020

Comments

@jrieken
Copy link
Member

jrieken commented Apr 29, 2020

  • have cell with errors
  • lock/unlock it
  • 馃悰 squiggle hides/shows

Apr-29-2020 08-54-19
@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug notebook labels Apr 29, 2020
@jrieken jrieken added this to the April 2020 milestone Apr 29, 2020
@connor4312
Copy link
Member

I see squiggles in this cell:

Version: 1.45.0-insider (user setup)
Commit: a0fe37870c42e0704a492cdc6b8550b4cf23f63c
Date: 2020-04-30T05:39:08.281Z
Electron: 7.2.2
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18363

@connor4312 connor4312 reopened this Apr 30, 2020
@connor4312 connor4312 added the verification-found Issue verification failed label Apr 30, 2020
@jrieken
Copy link
Member Author

jrieken commented May 1, 2020 •
edited

I see squiggles in this cell:

That's a good thing ;-). This issue is about showing squiggle for readonly cells. The fact that you see a squiggle is likely this bug: microsoft/vscode-github-issue-notebooks@ba849fb

@jrieken jrieken closed this as completed May 1, 2020
@jrieken jrieken removed the verification-found Issue verification failed label May 1, 2020
@connor4312
Copy link
Member

Oh, I misread the issue. Sounds like this is working as intended.

@connor4312 connor4312 added the verified Verification succeeded label May 1, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded
Projects
None yet
Milestone
April 2020
Development

No branches or pull requests
3 participants
@roblourens @jrieken @connor4312