Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs: allow to control scrolling direction #96544

Closed
bpasero opened this issue Apr 29, 2020 · 3 comments
Closed

Tabs: allow to control scrolling direction #96544

bpasero opened this issue Apr 29, 2020 · 3 comments
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code workbench-tabs VS Code editor tab issues
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Apr 29, 2020

This should impact both the scrolling direction ("natural", "reverse") as well as when switching tabs for mouse scroll is enabled.

@bpasero bpasero added feature-request Request for new features or functionality workbench-tabs VS Code editor tab issues labels Apr 29, 2020
@bpasero bpasero added this to the Backlog milestone Apr 29, 2020
@RossBrunton
Copy link

Why should this affect switching tabs via the scroll wheel? It's entirely reasonable for people to want the scroll direction for the tab bar to be different than the vertical scrolling. Why are we requiring that one setting control both?

@bpasero
Copy link
Member Author

bpasero commented May 8, 2020

From #96405

@vscodebot vscodebot bot added the *out-of-scope Posted issue is not in scope of VS Code label Nov 7, 2020
@Chrysaloid
Copy link

Replying to @joaomoreno in #96405 here because that issue is closed.

Is reverse really important to have as a setting?

YES. IT IS!

And if we reverse it, shouldn't the scrolling be reverse too?

No.

Those two should be identical right?

No. They absolutely shouldn't. They should be separate settings.

Why your solution to the problem was to throw IMPORTANT PART OF THE FEATURE to the trash?

And how it is even possible for the reverse to work differently than normal? Why didn't you just copy your code for normal and just swap those 2 important values/function calls that tell the VSC to go to the next tab or the previous one? WHY?

PLEASE! FOR THE LOVE OF GOD! Add the reverse back! For me reverse is more natural as I am right-handed and my mouse is pointing slightly to the right so scrolling up should switch to the tab on the right.

Of course, right now, because of many possible users that have changed this setting, you should probably add another boolean setting (probably named "workbench.editor.scrollToSwitchTabsDirectionNormal") that would defaultly be set to true so those users won't notice anything.

As for now, for other power users like me who might find this issue before you fix it, here's AHK script that remaps WheelUp to WheelDown and vice-versa when the mouse is in the tab bar and VSC is the active window.

#NoEnv
#SingleInstance Force
CoordMode, Mouse, Relative
SendMode Input
SetTitleMatchMode, 2

#IfWinActive ahk_exe Code.exe
$WheelUp::
MouseGetPos,,yaxis
if (84 <= yaxis and yaxis <= 164) {
   Send, {WheelDown}
} else {
   Send, {WheelUp}
}
Return

$WheelDown::
MouseGetPos,,yaxis
if (84 <= yaxis and yaxis <= 164) {
   Send, {WheelUp}
} else {
   Send, {WheelDown}
}
Return
#IfWinActive

!Insert::ExitApp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code workbench-tabs VS Code editor tab issues
Projects
None yet
Development

No branches or pull requests

4 participants
@RossBrunton @bpasero @Chrysaloid and others