Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search editor does not persist the 'exclude configured files' setting #97180

Closed
mjbvz opened this issue May 7, 2020 · 1 comment
Closed

Search editor does not persist the 'exclude configured files' setting #97180

mjbvz opened this issue May 7, 2020 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug search-editor verified Verification succeeded
Milestone

Comments

@mjbvz
Copy link
Contributor

mjbvz commented May 7, 2020

Issue Type: Bug

repro

  1. Do a normal search
  2. Make sure excluded configured files is enabled
  3. Now open the results in a search editor

Bug
The search editor does not have 'exclude configured files' enabled, which makes searches very slow in projects with node_modules:

Screen Shot 2020-05-07 at 12 31 15 PM

VS Code version: Code - Insiders 1.45.0-insider (d69a79b, 2020-05-06T08:25:01.764Z)
OS version: Darwin x64 19.4.0

System Info
Item Value
CPUs Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off_ok
webgl: enabled
webgl2: enabled
Load (avg) 2, 2, 2
Memory (System) 32.00GB (2.04GB free)
Process Argv -psn_0_45714326
Screen Reader no
VM 11%
@mjbvz mjbvz changed the title Search editor does not persist the 'exclude configured files' section Search editor does not persist the 'exclude configured files' setting May 7, 2020
@JacksonKearl JacksonKearl added bug Issue identified by VS Code Team member as probable bug search-editor labels May 7, 2020
@JacksonKearl JacksonKearl added this to the May 2020 milestone May 7, 2020
@JacksonKearl
Copy link
Contributor

Thanks!

@lszomoru lszomoru added the verified Verification succeeded label Jun 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug search-editor verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants