Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to control the sash size #97266

Merged
merged 4 commits into from May 12, 2020
Merged

Add setting to control the sash size #97266

merged 4 commits into from May 12, 2020

Conversation

lszomoru
Copy link
Member

@lszomoru lszomoru commented May 8, 2020

This PR fixes #68962

@lszomoru lszomoru requested a review from joaomoreno May 8, 2020 15:02
@lszomoru lszomoru self-assigned this May 8, 2020
Copy link
Member

@joaomoreno joaomoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments, looks great overall!

src/vs/base/browser/ui/sash/sash.ts Outdated Show resolved Hide resolved
src/vs/base/browser/ui/sash/sash.ts Outdated Show resolved Hide resolved
src/vs/base/browser/ui/sash/sash.ts Outdated Show resolved Hide resolved
src/vs/base/browser/ui/sash/sash.ts Outdated Show resolved Hide resolved
src/vs/base/browser/ui/sash/sash.ts Outdated Show resolved Hide resolved
src/vs/base/browser/ui/sash/sash.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/sash/browser/sash.ts Outdated Show resolved Hide resolved
@lszomoru lszomoru requested a review from joaomoreno May 11, 2020 07:54
@lszomoru lszomoru requested a review from joaomoreno May 11, 2020 10:50
@lszomoru lszomoru added this to the May 2020 milestone May 12, 2020
@joaomoreno
Copy link
Member

Great job! 👏

@joaomoreno joaomoreno merged commit 92cf6f4 into master May 12, 2020
@joaomoreno joaomoreno deleted the lszomoru/sash-setting branch May 12, 2020 09:43
@YBogomolov
Copy link

It looks like sashes are positioned incorrectly after this PR was merged.

image

@YBogomolov
Copy link

YBogomolov commented May 13, 2020

Moreover, when I move that invisible horizontal sash, left panel is resized instead of bottom one.

cc @lszomoru @joaomoreno

@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Splitview: Support customizable sash width
3 participants