Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://monacotools.visualstudio.com/DefaultCollection/Monaco/_build/results?buildId=74724
This was bit surprising to see libffmpeg.dylib linked to the gpu helper, but it makes sense because how electron rewrites rpath https://github.com/electron/electron/blob/master/build/config/BUILD.gn
The ideal fix is to sign the libraries inside the
Electron framework
folder and remove this entitlement, will do that in a follow-up.