Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gpu helper entitlements #97546

Merged
merged 1 commit into from May 11, 2020
Merged

fix: gpu helper entitlements #97546

merged 1 commit into from May 11, 2020

Conversation

deepak1556
Copy link
Contributor

Fixes https://monacotools.visualstudio.com/DefaultCollection/Monaco/_build/results?buildId=74724

This was bit surprising to see libffmpeg.dylib linked to the gpu helper, but it makes sense because how electron rewrites rpath https://github.com/electron/electron/blob/master/build/config/BUILD.gn

 > otool -l /Applications/Visual\ Studio\ Code\ -\ Insiders.app/Contents/Frameworks/Code\ -\ Insiders\ Helper\ \(GPU\).app/Contents/MacOS/Code\ -\ Insiders\ Helper\ \(GPU\)  

Load command 13
          cmd LC_LOAD_DYLIB
      cmdsize 80
         name @rpath/Electron Framework.framework/Electron Framework (offset 24)
   time stamp 2 Wed Dec 31 16:00:02 1969
      current version 0.0.0
compatibility version 0.0.0

The ideal fix is to sign the libraries inside the Electron framework folder and remove this entitlement, will do that in a follow-up.

@deepak1556 deepak1556 self-assigned this May 11, 2020
@deepak1556 deepak1556 added this to the May 2020 milestone May 11, 2020
Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixed the issue with launching code for settings export in CI

@deepak1556 deepak1556 merged commit 5aa5fa5 into master May 11, 2020
@deepak1556 deepak1556 deleted the robo/fix_gpu_entitlement branch May 11, 2020 21:04
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants