Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighted text in editor should be string to be searched for #97914

Closed
csicky opened this issue May 15, 2020 · 4 comments
Closed

Highlighted text in editor should be string to be searched for #97914

csicky opened this issue May 15, 2020 · 4 comments

Comments

@csicky
Copy link

csicky commented May 15, 2020

Issue Type: Bug

I select a text in the editor, then click the search in the sidebar. Until now, the selected search was auto populated in the search box. Now it is not doing that.

https://www.loom.com/share/17b72bac896a429696251f363ee8221c

VS Code version: Code 1.45.1 (5763d90, 2020-05-14T08:27:35.169Z)
OS version: Windows_NT x64 10.0.18363

System Info
Item Value
CPUs AMD Ryzen 7 3700X 8-Core Processor (16 x 3600)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off_ok
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 15.93GB (8.91GB free)
Process Argv
Screen Reader no
VM 0%
Extensions (11)
Extension Author (truncated) Version
vscode-blink-mind awe 0.0.10
bracket-pair-colorizer Coe 1.0.61
vscode-eslint dba 2.1.5
gitlens eam 10.2.1
EditorConfig Edi 0.14.5
prettier-vscode esb 4.7.0
auto-close-tag for 0.5.7
favorites kdc 2.4.5
back-n-forth nic 3.0.2
vetur oct 0.24.0
nativescript Tel 0.11.0
@yume-chan
Copy link
Contributor

yume-chan commented May 15, 2020

See #91901 (comment).

A new setting, "search.seedOnFocus" has been added to control this behavior, and it defaults to false.

Sadly it didn't get mentioned in the Release Notes.

@csicky
Copy link
Author

csicky commented May 15, 2020

I don't know if it is the same, but I have this checkbox checked and it still not working:
image

@csicky
Copy link
Author

csicky commented May 15, 2020

OK, I searched now on search.seedOnFocus and found that one checkbox. Now it is working. The one in the above checkbox is probably the small search in top right corner of the editor. It is confusing a bit, maybe the one in the screenshot above could be placed next to this one for people to know even if the meaning of the text is similar, there are actually two settings.

@csicky csicky closed this as completed May 15, 2020
@csicky
Copy link
Author

csicky commented May 15, 2020

@yume-chan thank you for clarifying it.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants