vim vg$ only moved the selection, it does not select

[Tyriar]

• VSCode Version: Code - Insiders 1.4.0-insider (fc167f8, 2016-07-26T05:12:44.554Z)
• OS Version: Linux x64 4.4.0-28-generic, Ubuntu 16.04
  Test: Evaluate API gaps for better VIM support #9699

Steps to Reproduce:

1. Open a file
2. Go to the middle of a line with content
3. Type "vg$", notice the cursor is only moved, no selection

[rebornix]

@sandy081 I can repro this issue. Previously when I tried this comamnd with inSelectionMode set as true, Code will help select the line or chars but now it didn't work. There is no code change in Vim side so can you help confirm is it a regression or maybe API signagure update?

[rebornix]

We have similar selection issue with vg0 (wrappedLineStart) and vg^ (nonChar) as well.

[sandy081]

As mentioned in #9732, this is an implementation issue in Vim sample extension. In Vim, in normal or visual mode, we always adjust the end of the line position to the one before that. So during selection, Vim sample extension is adjusting just the position instead of the complete selection.

During investigation, I also figured out that #9802 is a different issue than this.
vg0, vg^, vg$ are excluding the last character.

[sandy081]

This issue was moved to microsoft/vscode-samples#8