YAML Syntax highlignting doesnt include multiline scalars anymore

[MaxRink]

• VSCode Version: 1.45.1
• OS Version: Win10x86

Steps to Reproduce:
In previous versions vscode linted yaml in multiline scalars, now it doesnt anymore:
This happens without ANY plugins installed.

1.45.1

1.39.1

It also happens with the insider build (e.g. 1.46)

Does this issue occur when all extensions are disabled?: Yes

[alexr00]

Can you please provide a copy/paste-able example?

[MaxRink]

sure

---
apiVersion: v1
kind: ConfigMap
metadata:
  name: nginx-ingress-controller-customer-configmap
  namespace: ingress-system
data:
  values.yaml: |
    service:
      annotations:
        metallb.universe.tf/allow-shared-ip: "10.27.50.35/32"
      loadBalancerIP: "10.27.50.35"

[alexr00]

I can see the repro. This is very odd though, since the yaml grammar hasn't changed since 2017. It looks like this started with version 1.41.
Starting with 1.41, the scope for service in your example is string.unquoted.block.yaml.
In 1.40, the scope of service was entity.name.tag.yaml, string.unquoted.plain.out.yaml.

It looks like whatever grammar that GitHub is using does the same thing.

@alexdima, before I spend more time looking into this, do you know of any changes vscode textmate that started with 1.41 that could have changed this?

[alexdima]

Yes, here is what steps I used to track them down.

• 1.40 shipped with vscode-textmate@4.2.2 -- https://github.com/microsoft/vscode/blob/release/1.40/package.json#L55
• 1.41 shipped with vscode-textmate@4.4.0 -- https://github.com/microsoft/vscode/blob/release/1.41/package.json#L55

If using tags to publish to npm (which vscode-textmate does), it is possible to use github to find out the changes: microsoft/vscode-textmate@v4.2.2...v4.4.0

From looking at those changes, this change mentions yaml explicitly -- microsoft/vscode-textmate#119

I can use the inspect tool to investigate.

[alexdima]

This appears to be correct. This is a direct consequence of the fix for microsoft/vscode-textmate#119 .

It is expected that the fix for microsoft/vscode-textmate#119 changes this between VS Code versions. The new behaviour is aligned with how TextMate parses using this same grammar:

So TL;DR the old version of vscode appears to look better, but it was wrong.