Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom menus should absorb keystrokes and dismiss if not mnemonic (letter) #99121

Open
stevencl opened this issue Jun 2, 2020 · 4 comments
Open
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug menus Menu items and widget issues
Milestone

Comments

@stevencl
Copy link
Member

stevencl commented Jun 2, 2020

Testing #97801

Choose the step into targets command
See a list of targets appear
Ignore list and press F10
List of targets remains in view
Expected: list of targets to close

@isidorn
Copy link
Contributor

isidorn commented Jun 2, 2020

Hmm agree that it should auto close, however on Mac we use a native context menu, and thus users can not even execute Step Over with F10, since VS Code is blocked while a context menu is shown.

It is a bit strange that when custom context menus are shown we allow commands to be executed via global keybindings.

fyi @sbatten

@isidorn isidorn added the under-discussion Issue is under discussion for relevance, priority, approach label Jun 2, 2020
@sbatten
Copy link
Member

sbatten commented Jun 2, 2020

I can try putting a listener on the same div that blocks the mouse from interacting with anything to absorb all keystrokes, though I'm not sure of the consequences. It looks like native menus dismiss the context view on f-keys, but absorb letters (in case they are mnemoncis)

@isidorn
Copy link
Contributor

isidorn commented Jun 3, 2020

@sbatten I think we should behave like native menus as much as possible.
Though I would suggest to only do this change on a start of milestone so we have enuogh time to get feedback.

@isidorn
Copy link
Contributor

isidorn commented Sep 8, 2020

I do not plan to tackle this on the debug side, thus forwarding to @sbatten so he can decide if he wants to tackle it on the menu side

@isidorn isidorn assigned sbatten and unassigned isidorn Sep 8, 2020
@sbatten sbatten changed the title List of targets doesn't disappear after taking another action Custom menus should absorb keystrokes and dismiss if not mnemonic (letter) Oct 20, 2020
@sbatten sbatten added bug Issue identified by VS Code Team member as probable bug menus Menu items and widget issues and removed under-discussion Issue is under discussion for relevance, priority, approach labels Oct 20, 2020
@sbatten sbatten added this to the On Deck milestone Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug menus Menu items and widget issues
Projects
None yet
Development

No branches or pull requests

3 participants