Shift+enter notebook behavior is odd

[Tyriar]

Testing #98821

Disclaimer: I don't know how other notebooks behave, but I know shift+enter as run from kusto.

Shift+Enter appears to do the following:

• Empty cell: Creates a new cell underneath
• Non-empty cell: Runs the cell and then focuses the next cell after it's finished(???)
• Non-empty running cell(???): Focus and scrolls to the next cell. the textarea isn't focused though

It does so many things, some of them are broken (scrolling but breaking focus state?) and one of them is time based (when running cell).

[roblourens]

It is "execute and focus next". When there is no next cell, it creates a next cell - that should be the only time it creates a new cell. I think your gif shows that. One bug is, it should focus the next cell immediately and not wait for execution to finish.

[roblourens]

All of this matches JupyterLab (except the bug)

[Tyriar]

@roblourens it's also focusing the next cell list item sometimes and the textarea other times. This isn't right surely?

[roblourens]

I see that issue - it should match whether the active cell editor is focused but doesn't do it consistently. Also an issue with alt+enter

[roblourens]

I don't know whether we will want that - it doesn't match JupyterLab but feels right to me. Leaving it for now.

[Tyriar]

I see that issue - it should match whether the active cell editor is focused but doesn't do it consistently. Also an issue with alt+enter

Is this tracked? The inconsistency is very annoying, it seems to only focus the textarea if it's a new textarea, not an existing one:

[roblourens]

That was also fixed in my commit above

[Tyriar]

@roblourens the focus behavior is the opposite to what I was expecting where the cell is focused, not the textarea, just making sure it was intentional? To start working on the next cell now is shift+enter, enter, typing, as opposed to shift+enter, typing.

[roblourens]

It should focus the next cell's editor only if the active cell's editor is focused when you use the command. Does that make sense? Is that not what you see?

[Tyriar]

No it doesn't happen:

It also doesn't happen if the output was already there or on the last cell either:

[roblourens]

I see flakiness, one more try

[Tyriar]

Thanks, works as expected now 👍