Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook cell drag and drop interferes with editor tab drag and drop #99327

Closed
JacksonKearl opened this issue Jun 4, 2020 · 3 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues insiders-released Patch has been released in VS Code Insiders notebook verified Verification succeeded
Milestone

Comments

@JacksonKearl
Copy link
Contributor

When dragging a notebook editor tab onto itself for splitting, it now triggers drag hover events in the editor and it it difficult to trigger the editor split event.

@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug debt Code quality issues notebook labels Jun 4, 2020
@roblourens roblourens added this to the June 2020 milestone Jun 4, 2020
@roblourens
Copy link
Member

roblourens commented Jun 4, 2020

Showing the dragover ui for non-cell dragging was fixed, but I still can't trigger the editor split overlay without going to the tab bar.

@roblourens
Copy link
Member

This is related to moving the notebook editor out of the main grid view. We add drag listeners to the .content element, but they are never triggered when dragging a file/editor into that view because the notebook is covering the whole area. We need a way to add the same listeners to an editor which is outside of the main flow, or have the editor forward those events to the EditorDropTarget in some other way.

@rebornix
Copy link
Member

rebornix commented Jun 8, 2020

As we discussed offline, we can take a look at how Webview Editor does it.

@JacksonKearl JacksonKearl added the verified Verification succeeded label Jul 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues insiders-released Patch has been released in VS Code Insiders notebook verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@roblourens @rebornix @JacksonKearl and others