Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reloading the window does not retain the revealed position of the cell #99349

Closed
sandy081 opened this issue Jun 4, 2020 · 4 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook polish Cleanup and polish issue verified Verification succeeded
Milestone

Comments

@sandy081
Copy link
Member

sandy081 commented Jun 4, 2020

In the attached video, see how after reload the last cell's reveal position is getting changed

Kapture 2020-06-04 at 11 40 46

@rebornix rebornix added bug Issue identified by VS Code Team member as probable bug notebook labels Jun 5, 2020
@rebornix rebornix added this to the June 2020 milestone Jun 5, 2020
@rebornix
Copy link
Member

This one was already fixed in master now. However you can only test it after #100783 is fixed.

@sandy081
Copy link
Member Author

sandy081 commented Jul 2, 2020

I can still reproduce this

Kapture 2020-07-02 at 10 28 47

@sandy081 sandy081 reopened this Jul 2, 2020
@sandy081 sandy081 added the verification-found Issue verification failed label Jul 2, 2020
@bpasero bpasero added the verified Verification succeeded label Jul 2, 2020
@rebornix rebornix removed verification-found Issue verification failed verified Verification succeeded labels Jul 6, 2020
@rebornix rebornix modified the milestones: June 2020, July 2020 Jul 6, 2020
@rebornix rebornix added the polish Cleanup and polish issue label Jul 6, 2020
@rebornix
Copy link
Member

rebornix commented Jul 6, 2020

This issue can be reproduced by

  • create github issue notebook with content
[
  {
    "kind": 1,
    "language": "markdown",
    "value": "# this is header\n\n## this is header 2\n\n# header 1\n\n## header 2\n\n### header 3\n\n# header 1\n\n## header 2\n\n# header 1\n\n## header 2\n\n### header 3",
    "editable": true
  },
  {
    "kind": 2,
    "language": "github-issues",
    "value": "repo:microsoft/vscode-atom-keybindings"
  },
  {
    "kind": 1,
    "language": "markdown",
    "value": "# another header"
  }
]
  • open, turn all markdown cells into edit mode
  • focus the last markdown cell editor
  • reload

@roblourens
Copy link
Member

This is fixed, probably by that other scroll position fix

@sandy081 sandy081 added the verified Verification succeeded label Aug 6, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook polish Cleanup and polish issue verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants