onDidEndTaskProcess not called when task terminal closed with vscode.TaskRevealKind.Silent

[badsyntax]

• VSCode Version: 1.46.0
• OS Version: MacOS Catalina

Steps to Reproduce:

(Note the task runs read which will probably only work on Linux/MacOS)

1. Clone/download this repo: https://github.com/badsyntax/vscode-executetask-test-example
2. npm i
3. npm run compile
4. Open vscode
5. Open extension.ts and place some breakpoints within onDidStartTaskProcess and onDidEndTaskProcess
6. Run the Run Extension launch config

Now note the terminal for this task is created. Also note the icon in the statusbar shows the running task. If you close the terminal using the "Bin" button in the terminal panel, the onDidEndTaskProcess handler is not called, but the "running tasks" icon in the statusbar has disappeared and the task has definitely ended.
Restart the extension by running "Run Extension". Open the task terminal. If you send a SIGINT signal (cmd +c) to the terminal, the onDidEndTaskProcess handler is called.

Now change the task.presentationOptions.reveal to vscode.TaskRevealKind.Always, and clicking on the "Bin" button next to the terminal will cause onDidEndTaskProcess to be called.

So it seems like an issue with reveal: vscode.TaskRevealKind.Silent.

Does this issue occur when all extensions are disabled?: Yes

[alexr00]

Thank you providing a repo with a repro!

[alexr00]

There was an exception occurring that was preventing onDidEndTaskProcess from firing. I have pushed a fix. If you can, please let me know if it fixes the issue for you in the next Insiders build.

[badsyntax]

Awesome, thanks for the quick fix! Will test with the next insiders build 👍

[badsyntax]

I have verified this changes fixes the bug. Thanks!

[alexr00]

Thanks for verifying!