Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown extension is not using codicons? #99976

Closed
bpasero opened this issue Jun 12, 2020 · 1 comment
Closed

Markdown extension is not using codicons? #99976

bpasero opened this issue Jun 12, 2020 · 1 comment
Assignees
@mjbvz @miguelsolorio
Labels
bug Issue identified by VS Code Team member as probable bug icons-product Issues for in-product icons insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
June 2020

Comments

@bpasero
Copy link
Member

bpasero commented Jun 12, 2020 •
edited

I think the icons are not aligned well:

image

image

@misolori didn't we adopt codicons for all our built in extensions?
@miguelsolorio
Copy link
Contributor

Good catch, I thought we had already updated these. Fixed. Worth noting that we can't update the preview icon to use codicons until #90616 is fixed.

@miguelsolorio miguelsolorio added this to the June 2020 milestone Jun 12, 2020
@miguelsolorio miguelsolorio added bug Issue identified by VS Code Team member as probable bug icons-product Issues for in-product icons labels Jun 12, 2020
@miguelsolorio miguelsolorio self-assigned this Jun 12, 2020
@bpasero bpasero added the verified Verification succeeded label Jun 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

@miguelsolorio miguelsolorio

Labels
bug Issue identified by VS Code Team member as probable bug icons-product Issues for in-product icons insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
June 2020
Development

No branches or pull requests
4 participants
@bpasero @mjbvz @miguelsolorio and others