Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown cell doesn't always update when editing in split notebook editor #99995

Closed
roblourens opened this issue Jun 12, 2020 · 2 comments · Fixed by #100545
Closed

Markdown cell doesn't always update when editing in split notebook editor #99995

roblourens opened this issue Jun 12, 2020 · 2 comments · Fixed by #100545
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded
Milestone

Comments

@roblourens
Copy link
Member

  • Open a notebook with a markdown cell
  • Split it
  • Edit a markdown cell on one side, see that it's not updated on the other side in preview mode
  • If it works, repeat a couple times

Seems that the right events are being fired, but getText in the viewmodel returns the old text. If I put the preview cell into edit mode, the editor has the right contents.

Any idea what's going on @rebornix? I touched this area recently but I can still repro after reverting my changes.

Pushed a1feacf because I removed that and I think I shouldn't have.

@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug notebook labels Jun 12, 2020
@roblourens roblourens added this to the June 2020 milestone Jun 12, 2020
@roblourens roblourens self-assigned this Jun 12, 2020
@roblourens
Copy link
Member Author

Now I've really broken it

Jun-12-2020 08-38-31

@rebornix rebornix self-assigned this Jun 17, 2020
@rebornix
Copy link
Member

I was not able to reproduce this issue with #100545 .

@rebornix rebornix linked a pull request Jun 24, 2020 that will close this issue
3 tasks
@lramos15 lramos15 added the verified Verification succeeded label Jul 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants